Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consistent-type-imports] new rule request #1720

Open
villelahdenvuo opened this issue Feb 11, 2024 · 0 comments
Open

[consistent-type-imports] new rule request #1720

villelahdenvuo opened this issue Feb 11, 2024 · 0 comments
Labels
package: eslint-plugin Angular-specific TypeScript rules triage This issue needs to be looked at and categorized by a maintainer

Comments

@villelahdenvuo
Copy link

Description of the issue

ESLint has a great rule https://typescript-eslint.io/rules/consistent-type-imports/ but it doesn't work with Angular as it doesn't detect the DI pattern of Angular and flags classes as being used as types when Angular needs to keep the references.

I was wondering if it would be too difficult to add the same rule to the Angular plugin extending the existing rule and just ignoring places where DI is being used e.g. constructors?

@villelahdenvuo villelahdenvuo added package: eslint-plugin Angular-specific TypeScript rules triage This issue needs to be looked at and categorized by a maintainer labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: eslint-plugin Angular-specific TypeScript rules triage This issue needs to be looked at and categorized by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant