Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-template): [i18n] allow more attributes by default #1220

Conversation

abaran30
Copy link
Contributor

Resolves #1214.

This pull request enhances the default allowed HTML attributes for i18n.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #1220 (6f9e581) into main (de2994c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1220   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files         162      162           
  Lines        3141     3141           
  Branches      506      506           
=======================================
  Hits         2766     2766           
  Misses        261      261           
  Partials      114      114           
Flag Coverage Δ
unittest 88.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin-template/src/rules/i18n.ts 94.00% <100.00%> (ø)

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Adrian!

@JamesHenry JamesHenry merged commit 4232b1c into angular-eslint:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] Ignore more HTML attributes by default
3 participants