Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fast linting by default, set eslint and typescript-eslint recommended #1212

Merged
merged 1 commit into from Nov 19, 2022

Conversation

JamesHenry
Copy link
Member

No description provided.

@JamesHenry JamesHenry added the BREAKING CHANGE This is a breaking change and should only be released as part of a new major version label Nov 19, 2022
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #1212 (cd5d5b7) into next-major-release/v15 (333fe1b) will decrease coverage by 0.33%.
The diff coverage is 67.85%.

@@                    Coverage Diff                     @@
##           next-major-release/v15    #1212      +/-   ##
==========================================================
- Coverage                   88.14%   87.81%   -0.34%     
==========================================================
  Files                         161      161              
  Lines                        3088     3102      +14     
  Branches                      499      505       +6     
==========================================================
+ Hits                         2722     2724       +2     
- Misses                        253      262       +9     
- Partials                      113      116       +3     
Flag Coverage Δ
unittest 87.81% <67.85%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/schematics/src/add-eslint-to-project/index.ts 66.66% <0.00%> (-8.34%) ⬇️
...s/schematics/src/convert-tslint-to-eslint/index.ts 52.12% <ø> (ø)
packages/schematics/src/application/index.ts 87.50% <50.00%> (-12.50%) ⬇️
packages/schematics/src/library/index.ts 87.50% <50.00%> (-12.50%) ⬇️
packages/builder/src/lint.impl.ts 80.30% <62.50%> (-12.43%) ⬇️
packages/schematics/src/ng-add/index.ts 75.47% <100.00%> (ø)
packages/schematics/src/utils.ts 80.00% <100.00%> (-0.14%) ⬇️

@JamesHenry JamesHenry marked this pull request as ready for review November 19, 2022 14:03
@JamesHenry JamesHenry merged commit 1a53ef9 into next-major-release/v15 Nov 19, 2022
@JamesHenry JamesHenry deleted the no-project-by-default branch November 19, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This is a breaking change and should only be released as part of a new major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant