feat(eslint-plugin-template): [accessibility-elements-content] add allowList option #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit def4b21. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #1201 +/- ##
==========================================
- Coverage 88.16% 88.14% -0.03%
==========================================
Files 161 161
Lines 3085 3088 +3
Branches 498 499 +1
==========================================
+ Hits 2720 2722 +2
Misses 253 253
- Partials 112 113 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
abaran30
reviewed
Nov 16, 2022
| /** | ||
| * Default: `["aria-label","innerHtml","innerHTML","innerText","outerHTML","title"]` | ||
| */ | ||
| allowlist?: string[]; |
There was a problem hiding this comment.
Since other rule options are camel case, can we make this allowList?
…ase allowList option
sandikbarr
changed the title
abaran30
approved these changes
Nov 16, 2022
JamesHenry
approved these changes
Nov 17, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Nov 28, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular-eslint/builder](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2fbuilder/14.2.0/14.4.0) | | [@angular-eslint/eslint-plugin](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin/14.2.0/14.4.0) | | [@angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin-template/14.2.0/14.4.0) | | [@angular-eslint/schematics](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2fschematics/14.2.0/14.4.0) | | [@angular-eslint/template-parser](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2ftemplate-parser/14.2.0/14.4.0) | --- ### Release Notes <details> <summary>angular-eslint/angular-eslint (@​angular-eslint/builder)</summary> ### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/builder/CHANGELOG.md#​1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0) **Note:** Version bump only for package [@​angular-eslint/builder](https://github.com/angular-eslint/builder) #### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20) **Note:** Version bump only for package [@​angular-eslint/builder](https://github.com/angular-eslint/builder) ### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/builder/CHANGELOG.md#​1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1) **Note:** Version bump only for package [@​angular-eslint/builder](https://github.com/angular-eslint/builder) ### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/builder/CHANGELOG.md#​1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17) [Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0) **Note:** Version bump only for package [@​angular-eslint/builder](https://github.com/angular-eslint/builder) </details> <details> <summary>angular-eslint/angular-eslint (@​angular-eslint/eslint-plugin)</summary> ### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0) **Note:** Version bump only for package [@​angular-eslint/eslint-plugin](https://github.com/angular-eslint/eslint-plugin) #### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20) ##### Bug Fixes - **no-input-rename:** allow input aliases that match the directive name applied to an element ([#​1207](angular-eslint/angular-eslint#1207)) ([aff3344](angular-eslint/angular-eslint@aff3344)) ### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1) ##### Bug Fixes - **no-input-rename:** allow input aliases that match the directive name applied to an element ([#​1207](angular-eslint/angular-eslint#1207)) ([aff3344](angular-eslint/angular-eslint@aff3344)) ### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17) [Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0) **Note:** Version bump only for package [@​angular-eslint/eslint-plugin](https://github.com/angular-eslint/eslint-plugin) </details> <details> <summary>angular-eslint/angular-eslint (@​angular-eslint/eslint-plugin-template)</summary> ### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin-template/CHANGELOG.md#​1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0) ##### Features - **utils:** export template parser services ([#​1211](angular-eslint/angular-eslint#1211)) ([34a62d2](angular-eslint/angular-eslint@34a62d2)) #### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20) **Note:** Version bump only for package [@​angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/eslint-plugin-template) ### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin-template/CHANGELOG.md#​1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1) **Note:** Version bump only for package [@​angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/eslint-plugin-template) ### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin-template/CHANGELOG.md#​1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17) [Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0) ##### Features - **eslint-plugin-template:** \[accessibility-elements-content] add allowList option ([#​1201](angular-eslint/angular-eslint#1201)) ([3877f43](angular-eslint/angular-eslint@3877f43)) - **eslint-plugin-template:** \[no-inline-styles] add rule ([#​1162](angular-eslint/angular-eslint#1162)) ([7e1aadf](angular-eslint/angular-eslint@7e1aadf)) </details> <details> <summary>angular-eslint/angular-eslint (@​angular-eslint/schematics)</summary> ### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/schematics/CHANGELOG.md#​1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0) **Note:** Version bump only for package [@​angular-eslint/schematics](https://github.com/angular-eslint/schematics) #### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20) ##### Bug Fixes - update dependency eslint to v8.28.0 ([#​1210](angular-eslint/angular-eslint#1210)) ([c671e74](angular-eslint/angular-eslint@c671e74)) ### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/schematics/CHANGELOG.md#​1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1) ##### Bug Fixes - update dependency eslint to v8.28.0 ([#​1210](angular-eslint/angular-eslint#1210)) ([c671e74](angular-eslint/angular-eslint@c671e74)) ### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/schematics/CHANGELOG.md#​1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17) [Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0) **Note:** Version bump only for package [@​angular-eslint/schematics](https://github.com/angular-eslint/schematics) </details> <details> <summary>angular-eslint/angular-eslint (@​angular-eslint/template-parser)</summary> ### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/template-parser/CHANGELOG.md#​1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0) **Note:** Version bump only for package [@​angular-eslint/template-parser](https://github.com/angular-eslint/template-parser) #### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20) **Note:** Version bump only for package [@​angular-eslint/template-parser](https://github.com/angular-eslint/template-parser) ### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/template-parser/CHANGELOG.md#​1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20) [Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1) **Note:** Version bump only for package [@​angular-eslint/template-parser](https://github.com/angular-eslint/template-parser) ### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/template-parser/CHANGELOG.md#​1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17) [Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0) **Note:** Version bump only for package [@​angular-eslint/template-parser](https://github.com/angular-eslint/template-parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNi4zIiwidXBkYXRlZEluVmVyIjoiMzQuMjkuMiJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1648 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1169
Adds allowList option to the accessibility-elements-content rule to configure additional attributes, inputs, or attribute directives that satisfy the content criteria.