feat(eslint-plugin-template): [no-duplicate-attributes] Add option to ignore properties

[ssams]

This introduces a new option ignore on the @angular-eslint/template/no-duplicate-attributes rule to ignore reports from selected duplicate attributes.

Rationale

In some special cases presence of duplicate attributes may be required, this allows to keep the rule enabled whilst being capable of not generating errors/warnings on accepted duplicates.

For example, in our project we regularly need to apply both a static text attribute class="foo" together with a bound [class]=dynamicValue. In our project this is necessary to ensure the static class is always present, also including it in the dynamic property handled via the ngClass would cause it to appear only after all inputs have been updated, which in some cases can cause visual flickering due to the toggling of the class by the directive. Hence we need to be able to ignore reports on the class attribute, but want to keep using the rule for others.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 27eb768. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 7 targets

• Node v16.17.1 - nx run-many --target=integration-test --all --withRegistry
• Node v16.17.1 - nx run-many --target=test --all --parallel --codeCoverage
• Node v16.17.1 - nx run-many --target=typecheck --all --parallel
• Node v16.17.1 - nx run-many --target=build --all --parallel
• Node v14.20.1 - nx run-many --target=test --all --parallel
• Node v16.17.1 - nx run-many --target=check-rule-docs --all --parallel
• Node v14.20.1 - nx run-many --target=build --all --parallel

---

Sent with 💌 from NxCloud.

[JamesHenry]

Thank you @ssams. I'm not super familiar with the behaviour of the framework in the example you give, but adding this option is low effort and low risk so let's press ahead with it.

Please remove the different data types for ignore, an array of strings is all that is needed and simplifies both the usage and implementation

[ssams]

ok, I've changed the type to an array as requested

[JamesHenry]

Thanks a lot @ssams - we just need to regenerate the docs now that the options have changed.

You just need to run yarn update-rule-docs and commit the results

[ssams]

Thanks a lot @ssams - we just need to regenerate the docs now that the options have changed.

You just need to run yarn update-rule-docs and commit the results

done :-)

[codecov]

Codecov Report

Merging #1104 (27eb768) into main (9069282) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1104   +/-   ##
=======================================
  Coverage   87.69%   87.70%           
=======================================
  Files         157      157           
  Lines        2959     2961    +2     
  Branches      475      476    +1     
=======================================
+ Hits         2595     2597    +2     
  Misses        253      253           
  Partials      111      111           

Flag	Coverage Δ
unittest	87.70% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...plate/tests/rules/no-duplicate-attributes/cases.ts	100.00% <ø> (ø)
...ugin-template/src/rules/no-duplicate-attributes.ts	100.00% <100.00%> (ø)

[JamesHenry]

Thanks a lot @ssams!