feat(eslint-plugin-template): [attributes-order] add rule with fixer #1066

pmccloghrylaing · 2022-06-24T03:30:54Z

Continuation of #605

Fixes #127

…eslint#127)

…lar-eslint#127)

…r-eslint#127)

…iew suggestions

nx-cloud · 2022-06-24T03:30:56Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5267561. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

lachieh · 2022-08-18T14:04:44Z

@rafaelss95 @JamesHenry Any updates? Looks like the original issue for this was closed (#127). Would be great to get this rule in.

JamesHenry

I'm very sorry for the delay in reviewing this @pmccloghrylaing.

I feel that the language of "incorrect/correct" is too strong for this rule, as this is subjective with no runtime behaviour impact, so let's please use the suggested edits to make it more about "expectations" not being met.

You will also need to update the branch to the latest.

Many thanks!

packages/eslint-plugin-template/src/rules/attributes-order.ts

packages/eslint-plugin-template/src/utils/is-on-same-location.ts

Co-authored-by: James Henry <james@henry.sc>

JamesHenry · 2022-09-18T11:31:43Z

@pmccloghrylaing sorry one of my suggestions made via the github UI was borked because of the single quote usage within the string, you'll need to fix up locally

JamesHenry · 2022-09-26T11:43:54Z

Thanks @pmccloghrylaing this LGTM now, we just need to generate the rule docs then this can be merged.

You just need to run yarn update-rule-docs and commit the result

codecov · 2022-09-26T11:44:33Z

Codecov Report

Merging #1066 (5267561) into main (6c39138) will increase coverage by 0.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   87.40%   88.07%   +0.66%     
==========================================
  Files         150      159       +9     
  Lines        2843     3052     +209     
  Branches      459      491      +32     
==========================================
+ Hits         2485     2688     +203     
- Misses        252      253       +1     
- Partials      106      111       +5

Flag	Coverage Δ
unittest	`88.07% <100.00%> (+0.66%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin-template/src/index.ts	`68.62% <100.00%> (+1.96%)`	⬆️
...lint-plugin-template/src/rules/attributes-order.ts	`100.00% <100.00%> (ø)`
...gin-template/tests/rules/attributes-order/cases.ts	`100.00% <100.00%> (ø)`
...ugin-template/src/rules/no-duplicate-attributes.ts	`100.00% <0.00%> (ø)`
...template/src/utils/is-interactive-element/index.ts	`100.00% <0.00%> (ø)`
...lement/get-non-interactive-element-role-schemas.ts	`100.00% <0.00%> (ø)`
...t-plugin-template/src/utils/is-content-editable.ts	`100.00% <0.00%> (ø)`
...gin-template/src/utils/is-semantic-role-element.ts	`80.00% <0.00%> (ø)`
.../accessibility-interactive-supports-focus/cases.ts	`100.00% <0.00%> (ø)`
... and 7 more

rafaeldolfe · 2022-09-26T13:45:48Z

Was just looking for this! prettier-plugin-organize-attributes isn't quite working for me in Angular, hoping I can stick to one package with this being incorporated into angular-eslint. 😀

pmccloghrylaing · 2022-09-26T23:31:40Z

@JamesHenry - that's done.

Only issue I had is the relative path generated on Windows uses \ instead of /.

JamesHenry · 2022-09-26T23:56:03Z

Thanks again @pmccloghrylaing!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular-eslint/builder](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.1.2` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2fbuilder/14.1.2/14.2.0) | | [@angular-eslint/eslint-plugin](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.1.2` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin/14.1.2/14.2.0) | | [@angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.1.2` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin-template/14.1.2/14.2.0) | | [@angular-eslint/schematics](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.1.2` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2fschematics/14.1.2/14.2.0) | | [@angular-eslint/template-parser](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.1.2` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2ftemplate-parser/14.1.2/14.2.0) | --- ### Release Notes <details> <summary>angular-eslint/angular-eslint (@angular-eslint/builder)</summary> ### [`v14.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/builder/CHANGELOG.md#1420-httpsgithubcomangular-eslintangular-eslintcomparev1412v1420-2022-11-15) [Compare Source](angular-eslint/angular-eslint@v14.1.2...v14.2.0) **Note:** Version bump only for package [@angular-eslint/builder](https://github.com/angular-eslint/builder) #### [14.1.2](angular-eslint/angular-eslint@v14.1.1...v14.1.2) (2022-09-21) ##### Bug Fixes - **builder:** remove nrwl/devkit from builder implementation ([#1142](angular-eslint/angular-eslint#1142)) ([9d5a7fc](angular-eslint/angular-eslint@9d5a7fc)) #### [14.1.1](angular-eslint/angular-eslint@v14.1.0...v14.1.1) (2022-09-18) **Note:** Version bump only for package [@angular-eslint/builder](https://github.com/angular-eslint/builder) </details> <details> <summary>angular-eslint/angular-eslint (@angular-eslint/eslint-plugin)</summary> ### [`v14.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#1420-httpsgithubcomangular-eslintangular-eslintcomparev1412v1420-2022-11-15) [Compare Source](angular-eslint/angular-eslint@v14.1.2...v14.2.0) ##### Bug Fixes - update typescript-eslint packages to v5.38.1 ([#1152](angular-eslint/angular-eslint#1152)) ([8f6d0ef](angular-eslint/angular-eslint@8f6d0ef)) - update typescript-eslint packages to v5.43.0 ([#1190](angular-eslint/angular-eslint#1190)) ([2a4716a](angular-eslint/angular-eslint@2a4716a)) ##### Features - update typescript-eslint packages to v5.38.0 ([#1140](angular-eslint/angular-eslint#1140)) ([85b4b47](angular-eslint/angular-eslint@85b4b47)) #### [14.1.2](angular-eslint/angular-eslint@v14.1.1...v14.1.2) (2022-09-21) **Note:** Version bump only for package [@angular-eslint/eslint-plugin](https://github.com/angular-eslint/eslint-plugin) #### [14.1.1](angular-eslint/angular-eslint@v14.1.0...v14.1.1) (2022-09-18) ##### Bug Fixes - **eslint-plugin:** \[sort-ngmodule-metadata-arrays]: add intl support ([#1099](angular-eslint/angular-eslint#1099)) ([30d133b](angular-eslint/angular-eslint@30d133b)) </details> <details> <summary>angular-eslint/angular-eslint (@angular-eslint/eslint-plugin-template)</summary> ### [`v14.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin-template/CHANGELOG.md#1420-httpsgithubcomangular-eslintangular-eslintcomparev1412v1420-2022-11-15) [Compare Source](angular-eslint/angular-eslint@v14.1.2...v14.2.0) ##### Bug Fixes - update dependency aria-query to v5.1.3 ([#1183](angular-eslint/angular-eslint#1183)) ([7c5b299](angular-eslint/angular-eslint@7c5b299)) - update dependency axobject-query to v3.1.1 ([#1184](angular-eslint/angular-eslint#1184)) ([dcfd43d](angular-eslint/angular-eslint@dcfd43d)) - update typescript-eslint packages to v5.38.1 ([#1152](angular-eslint/angular-eslint#1152)) ([8f6d0ef](angular-eslint/angular-eslint@8f6d0ef)) - update typescript-eslint packages to v5.43.0 ([#1190](angular-eslint/angular-eslint#1190)) ([2a4716a](angular-eslint/angular-eslint@2a4716a)) ##### Features - **eslint-plugin-template:** \[accessibility-interactive-supports-focus] add rule ([#1134](angular-eslint/angular-eslint#1134)) ([d99d8c1](angular-eslint/angular-eslint@d99d8c1)) - **eslint-plugin-template:** \[accessibility-role-has-required-aria] add rule ([#1100](angular-eslint/angular-eslint#1100)) ([f684df0](angular-eslint/angular-eslint@f684df0)) - **eslint-plugin-template:** \[attributes-order] add rule with fixer ([#1066](angular-eslint/angular-eslint#1066)) ([4c789c7](angular-eslint/angular-eslint@4c789c7)) - **eslint-plugin-template:** \[no-duplicate-attributes] Add option to ignore properties ([#1104](angular-eslint/angular-eslint#1104)) ([018d390](angular-eslint/angular-eslint@018d390)) - update typescript-eslint packages to v5.38.0 ([#1140](angular-eslint/angular-eslint#1140)) ([85b4b47](angular-eslint/angular-eslint@85b4b47)) #### [14.1.2](angular-eslint/angular-eslint@v14.1.1...v14.1.2) (2022-09-21) **Note:** Version bump only for package [@angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/eslint-plugin-template) #### [14.1.1](angular-eslint/angular-eslint@v14.1.0...v14.1.1) (2022-09-18) ##### Bug Fixes - **eslint-plugin-template:** \[click-events-have-key-events]: handle additional outputs ([#1101](angular-eslint/angular-eslint#1101)) ([c608cdb](angular-eslint/angular-eslint@c608cdb)) </details> <details> <summary>angular-eslint/angular-eslint (@angular-eslint/schematics)</summary> ### [`v14.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/schematics/CHANGELOG.md#1420-httpsgithubcomangular-eslintangular-eslintcomparev1412v1420-2022-11-15) [Compare Source](angular-eslint/angular-eslint@v14.1.2...v14.2.0) ##### Bug Fixes - update dependency eslint to v8.27.0 ([#1189](angular-eslint/angular-eslint#1189)) ([d2ae95a](angular-eslint/angular-eslint@d2ae95a)) - update typescript-eslint packages to v5.38.1 ([#1152](angular-eslint/angular-eslint#1152)) ([8f6d0ef](angular-eslint/angular-eslint@8f6d0ef)) - update typescript-eslint packages to v5.43.0 ([#1190](angular-eslint/angular-eslint#1190)) ([2a4716a](angular-eslint/angular-eslint@2a4716a)) ##### Features - update dependency eslint to v8.24.0 ([#1148](angular-eslint/angular-eslint#1148)) ([5f30b2d](angular-eslint/angular-eslint@5f30b2d)) - update typescript-eslint packages to v5.38.0 ([#1140](angular-eslint/angular-eslint#1140)) ([85b4b47](angular-eslint/angular-eslint@85b4b47)) #### [14.1.2](angular-eslint/angular-eslint@v14.1.1...v14.1.2) (2022-09-21) **Note:** Version bump only for package [@angular-eslint/schematics](https://github.com/angular-eslint/schematics) #### [14.1.1](angular-eslint/angular-eslint@v14.1.0...v14.1.1) (2022-09-18) **Note:** Version bump only for package [@angular-eslint/schematics](https://github.com/angular-eslint/schematics) </details> <details> <summary>angular-eslint/angular-eslint (@angular-eslint/template-parser)</summary> ### [`v14.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/template-parser/CHANGELOG.md#1420-httpsgithubcomangular-eslintangular-eslintcomparev1412v1420-2022-11-15) [Compare Source](angular-eslint/angular-eslint@v14.1.2...v14.2.0) ##### Bug Fixes - update dependency eslint-scope to v7 ([#1156](angular-eslint/angular-eslint#1156)) ([05bd9e6](angular-eslint/angular-eslint@05bd9e6)) #### [14.1.2](angular-eslint/angular-eslint@v14.1.1...v14.1.2) (2022-09-21) **Note:** Version bump only for package [@angular-eslint/template-parser](https://github.com/angular-eslint/template-parser) #### [14.1.1](angular-eslint/angular-eslint@v14.1.0...v14.1.1) (2022-09-18) **Note:** Version bump only for package [@angular-eslint/template-parser](https://github.com/angular-eslint/template-parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1641 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

nickbullock and others added 6 commits July 8, 2021 15:58

Attributes order rule WIP

9fbba46

feat(eslint-plugin-template): [attributes-order] added rule (angular-…

d53d372

…eslint#127)

feat(eslint-plugin-template): [attributes-order] updated readme (angu…

25cf8f3

…lar-eslint#127)

feat(eslint-plugin-template): [attributes-order] run prettier (angula…

373b3c4

…r-eslint#127)

Merge remote-tracking branch 'remotes/pull/master' into attributes-order

9b96c65

feat(eslint-plugin-template): [attributes-order] Add fixer + code rev…

2e868f4

…iew suggestions

Merge branch 'main' into attributes-order

d4e3532

cmalard mentioned this pull request Sep 11, 2022

Incompatibility with other Prettier plugins NiklasPor/prettier-plugin-organize-attributes#14

Closed

JamesHenry requested changes Sep 18, 2022

View reviewed changes

pmccloghrylaing and others added 2 commits September 18, 2022 19:49

Update packages/eslint-plugin-template/src/rules/attributes-order.ts

56f46d4

Co-authored-by: James Henry <james@henry.sc>

Update packages/eslint-plugin-template/src/rules/attributes-order.ts

efb4595

Co-authored-by: James Henry <james@henry.sc>

pmccloghrylaing added 2 commits September 19, 2022 09:48

Merge remote-tracking branch 'remotes/pull/main' into attributes-order

39b228f

Fixed quotes and moved isOnSameLocation to attributes-order.ts

065cb2f

chore: update rule docs

5267561

JamesHenry merged commit 4c789c7 into angular-eslint:main Sep 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin-template): [attributes-order] add rule with fixer #1066

feat(eslint-plugin-template): [attributes-order] add rule with fixer #1066

pmccloghrylaing commented Jun 24, 2022 •

edited

nx-cloud bot commented Jun 24, 2022 •

edited

lachieh commented Aug 18, 2022

JamesHenry left a comment

JamesHenry commented Sep 18, 2022

JamesHenry commented Sep 26, 2022

codecov bot commented Sep 26, 2022 •

edited

rafaeldolfe commented Sep 26, 2022

pmccloghrylaing commented Sep 26, 2022

JamesHenry commented Sep 26, 2022

feat(eslint-plugin-template): [attributes-order] add rule with fixer #1066

feat(eslint-plugin-template): [attributes-order] add rule with fixer #1066

Conversation

pmccloghrylaing commented Jun 24, 2022 • edited

nx-cloud bot commented Jun 24, 2022 • edited

☁️ Nx Cloud Report

lachieh commented Aug 18, 2022

JamesHenry left a comment

Choose a reason for hiding this comment

JamesHenry commented Sep 18, 2022

JamesHenry commented Sep 26, 2022

codecov bot commented Sep 26, 2022 • edited

Codecov Report

rafaeldolfe commented Sep 26, 2022

pmccloghrylaing commented Sep 26, 2022

JamesHenry commented Sep 26, 2022

pmccloghrylaing commented Jun 24, 2022 •

edited

nx-cloud bot commented Jun 24, 2022 •

edited

codecov bot commented Sep 26, 2022 •

edited