From 19dd177137ceec8b7ab021246a26095f01f25366 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9CJamesHenry=E2=80=9D?= Date: Thu, 17 Nov 2022 16:25:20 +0400 Subject: [PATCH] feat(eslint-plugin): remove no-conflicting-lifecycle from recommended config The no-conflicting-lifecycle rule has been shown to be unreliable at enforcing its intended purpose, it is therefore not recommended for all workspaces. BREAKING CHANGE: no-conflicting-lifecycle is no longer included as part of the recommended config and if you wish to continue using it you will need to enable it yourself in your eslint config rules re #502 --- packages/eslint-plugin/src/configs/recommended.json | 1 - packages/eslint-plugin/src/rules/no-conflicting-lifecycle.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/eslint-plugin/src/configs/recommended.json b/packages/eslint-plugin/src/configs/recommended.json index 1b6325a99..abb9a4dc7 100644 --- a/packages/eslint-plugin/src/configs/recommended.json +++ b/packages/eslint-plugin/src/configs/recommended.json @@ -4,7 +4,6 @@ "@angular-eslint/component-class-suffix": "error", "@angular-eslint/contextual-lifecycle": "error", "@angular-eslint/directive-class-suffix": "error", - "@angular-eslint/no-conflicting-lifecycle": "error", "@angular-eslint/no-empty-lifecycle-method": "error", "@angular-eslint/no-host-metadata-property": "error", "@angular-eslint/no-input-rename": "error", diff --git a/packages/eslint-plugin/src/rules/no-conflicting-lifecycle.ts b/packages/eslint-plugin/src/rules/no-conflicting-lifecycle.ts index eb74ed130..1a448ef62 100644 --- a/packages/eslint-plugin/src/rules/no-conflicting-lifecycle.ts +++ b/packages/eslint-plugin/src/rules/no-conflicting-lifecycle.ts @@ -25,7 +25,7 @@ export default createESLintRule({ docs: { description: 'Ensures that directives not implement conflicting lifecycle interfaces.', - recommended: 'error', + recommended: false, }, schema: [], messages: {