Change order of tasks in connection reset #1262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a race condition, where a task can be returned an old connection instead of waiting, while another one already started the reset. Thanks for the analysis done by @yht804421715 and @gmbnomis . fixes redis#1138
|
This is replicated by #1270 which addresses several other thread-safety issues with the ConnectionPool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition, where a task can be returned an old
connection instead of waiting, while another one already started the reset.
Thanks for the analysis done by @yht804421715 and @gmbnomis .
fixes #1138
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.