Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce len call #1255

Closed
wants to merge 2 commits into from
Closed

reduce len call #1255

wants to merge 2 commits into from

Conversation

Deneby67
Copy link

reduce len call and up perfomance

@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #1255 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
- Coverage   92.56%   92.53%   -0.04%     
==========================================
  Files          20       20              
  Lines        6143     6145       +2     
==========================================
  Hits         5686     5686              
- Misses        457      459       +2
Impacted Files Coverage Δ
redis/connection.py 82.45% <100%> (+0.04%) ⬆️
redis/_compat.py 85.6% <0%> (-1.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1671ef2...14efae3. Read the comment docs.

@andymccurdy
Copy link
Contributor

Thanks. We definitely don't want to cache buffer_length as that changes every iteration of the loop. But I've merged the arg_length argument optimization.

@Deneby67 Deneby67 deleted the reduce-len-call branch January 2, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants