Pipeline.execute() doesn't short-circuit on empty command stack if it is watching keys #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is watching keys
Codecov Report
@@ Coverage Diff @@
## master #1234 +/- ##
==========================================
+ Coverage 92.33% 92.34% +0.01%
==========================================
Files 20 20
Lines 5948 5958 +10
==========================================
+ Hits 5492 5502 +10
Misses 456 456
Continue to review full report at Codecov.
|
|
This looks great, thanks. Merged into master. It'll go out in the next release. |
|
Awesome, thanks! Very impressed by your response time, thanks for being a great maintainer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline.execute() no longer short-circuits on empty command stack (eturns an empty list without running EXEC) if it is watching keys.
Closes #1233