Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks for Carousel.java when View is getting recycled e.g. in RecyclerView #714

Open
FloriJann opened this issue Sep 9, 2022 · 1 comment
Assignees
Labels
bug Something isn't working Release Validation

Comments

@FloriJann
Copy link

When Carousel.java is used within a RecyclerView and is getting attached and detached to the layout, the internal list "mList" holding the references for the child views gets bigger and bigger. As a result, the linking between internal data and displayed data gets out of sync, meaning wrong data gets displayed.

With every call of onAttachedToWindow the list grows but never gets cleared.

A simple fix might be to just clear the list when the Carousel gets detached from the view.

@FloriJann FloriJann added the bug Something isn't working label Sep 9, 2022
@camaelon
Copy link
Collaborator

@jswong65 Shane can you close this upon validation / next release? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Release Validation
Projects
None yet
Development

No branches or pull requests

3 participants