Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to CircularFlow #200

Merged

Conversation

rodrigomartind
Copy link
Contributor

Performance improvements in CircularFlow.

Grabacion.de.pantalla.2021-04-04.a.la.s.14.27.22.mov

@google-cla
Copy link

google-cla bot commented Apr 4, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@rodrigomartindMeli
Copy link
Contributor

@googlebot I consent

@rodrigomartind
Copy link
Contributor Author

@jafu888 @camaelon
After that this PR is merged, I will fix the xml in
/home/runner/work/constraintlayout/constraintlayout/projects/MotionLayoutVerification/app/src/main/res/layout/verification_922.xml:253: AAPT: error: '140' is incompatible with attribute circularflow_defaultRadius (attr) dimension.

circularflow_defaultRadius now change to a dimension.

@camaelon
Copy link
Collaborator

camaelon commented Apr 5, 2021

you have to modify the validation file using CircularFlow, as it still references the value as integer instead of Dp, so the check fails.

MotionLayoutVerification/app/src/main/res/layout/verification_922.xml:253

@rodrigomartindMeli
Copy link
Contributor

you have to modify the validation file using CircularFlow, as it still references the value as integer instead of Dp, so the check fails.

MotionLayoutVerification/app/src/main/res/layout/verification_922.xml:253

Done ✅

@camaelon camaelon merged commit b46bd70 into androidx:main Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants