Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring Chrome DevTools compile time configuration #28

Open
holsee opened this issue May 3, 2019 · 0 comments
Open

Configuring Chrome DevTools compile time configuration #28

holsee opened this issue May 3, 2019 · 0 comments

Comments

@holsee
Copy link
Contributor

holsee commented May 3, 2019

Following on from the discussion of System Environment Variable versus App Config for configuration of the Compile Time protocol target: #27

@andrewvy has expressed concern regarding the use of environment variable as a compile-time configuration option to signal which Chrome DevTool protocol version to be selected. There is merit in this objection so I am opening this issue for further discussion and resolution.

I am open to the use of config.ex (as @andrewvy points out this is what Logger uses to configure its macros) and would be happy enough with this to change as long as a sensible default remains when the configuration is not present on the inclusion of the CRI dependency 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant