Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URI as data for vcard PHOTO #170

Closed
SpamReceiver opened this issue Nov 7, 2019 · 2 comments · Fixed by #172
Closed

Allow URI as data for vcard PHOTO #170

SpamReceiver opened this issue Nov 7, 2019 · 2 comments · Fixed by #172

Comments

@SpamReceiver
Copy link

SpamReceiver commented Nov 7, 2019

Nextcloud has implemented a change to allow URI as data for VCards: nextcloud/server#13117
Consequently, I find in my database a number of VCFs 3.0 with:
BEGIN:VCARD
VERSION:3.0
PRODID:-//Sabre//Sabre VObject 4.1.6//EN
UID:C7821D49-BED0-0001-7F2A-E8507C67107F.vcf
FN:xxxx
ORG:xxxx
PHOTO;VALUE=URI:DATA:IMAGE/JPEG;BASE64\,/9j/4QAYRXhpZgAASUkqAAgAAAAAAAAAAAA

These photos are not recognized by carddav2fb und thus missing from the uploaded phonebook.

@andig
Copy link
Owner

andig commented Nov 7, 2019

/cc @blacksenator - is that something you would like to look into?

@blacksenator
Copy link
Collaborator

blacksenator commented Nov 7, 2019

Okay

@SpamReceiver - according to this RFC 2426 specification:

Type encoding: The encoding MUST be reset to "b" using the ENCODING parameter in order to specify inline, encoded binary data. If the value is referenced by a URI value, then the default encoding of 8bit is used and no explicit ENCODING parameter is needed.
Type value: A single value. The default is binary value. It can also be reset to uri value. The uri value can be used to specify a value outside of this MIME entity

It would be extremly helpfull, if you can send me a few of your VCFs (anonymized but with original imagadata!) for test purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants