Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vunnel should retain "not applicable" items so that grype can use them as negative evidence #268

Open
willmurphyscode opened this issue Aug 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@willmurphyscode
Copy link
Contributor

What would you like to be added:

Right now, at least 2 vunnel providers (RHEL and Mariner), simply drop vulnerabilities that the feed considers "not applicable". Instead, we should keep them in the database with fixed status "not applicable" and version constraint < 0.

Why is this needed:

When matching, in order to avoid false positives, grype should be able to consider the explicit claim by the feed operators that a give package is not vulnerable as evidence that it is not vulnerable. Right now, a distro feed being silent on a given CVE, and a distro feed explicitly reporting that the CVE is not applicable to their package, both result in having no row in the grype database for that CVE/namespace/package. But the explicit claim by the feed operators that a given package is not vulnerable is valuable evidence and should be retained.

More details at anchore/grype#1426 for the reason grype should have access to negative matches.

Additional context:

Mariner provider dropping N/A matches:

if d.metadata and d.metadata.patchable and d.metadata.patchable in IGNORED_PATCHABLE_VALUES:
continue

RHEL provider dropping "Not affected" matches:

elif state in [
"New",
"Not affected",
"Under investigation",

@willmurphyscode willmurphyscode added the enhancement New feature or request label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant