Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version info and remove double config call #977

Merged
merged 1 commit into from May 2, 2022

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented May 2, 2022

Add back version info to INFO level logs and remove double call to config debug in attest

Signed-off-by: Christopher Phillips christopher.phillips@anchore.com

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@github-actions
Copy link

github-actions bot commented May 2, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.46ms ± 2%    1.13ms ± 1%  -22.11%  (p=0.016 n=5+4)
ImagePackageCatalogers/python-package-cataloger-2            3.69ms ± 1%    2.97ms ± 0%  -19.48%  (p=0.016 n=4+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.19ms ± 1%    0.93ms ± 0%  -21.61%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         798µs ± 2%     617µs ± 0%  -22.64%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     931µs ± 2%     728µs ± 1%  -21.79%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      823µs ± 1%     641µs ± 1%  -22.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      16.9ms ± 2%    13.8ms ± 1%  -18.38%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.50ms ± 5%    1.16ms ± 2%  -22.44%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.73µs ± 1%    2.03µs ± 1%  -25.85%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               184kB ± 0%     184kB ± 0%   +0.23%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             895kB ± 0%     896kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     196kB ± 0%     196kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         140kB ± 0%     140kB ± 0%   -0.41%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     176kB ± 0%     176kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      163kB ± 0%     164kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.30MB ± 0%    3.29MB ± 0%   -0.22%  (p=0.032 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.24MB ± 0%    1.24MB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               3.66k ± 0%     3.66k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             14.8k ± 0%     14.8k ± 0%     ~     (p=0.968 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     4.94k ± 0%     4.94k ± 0%     ~     (p=0.206 n=4+5)
ImagePackageCatalogers/javascript-package-cataloger-2         2.72k ± 0%     2.72k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     3.95k ± 0%     3.95k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      4.02k ± 0%     4.02k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       52.2k ± 0%     52.2k ± 0%   -0.03%  (p=0.016 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      4.83k ± 0%     4.83k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)

@spiffcs spiffcs changed the title add back version info and remove double config call add version info and remove double config call May 2, 2022
@spiffcs spiffcs enabled auto-merge (squash) May 2, 2022 14:27
@spiffcs spiffcs merged commit 4ce2edd into main May 2, 2022
@spiffcs spiffcs deleted the add-back-version-info branch May 2, 2022 14:54
spiffcs added a commit that referenced this pull request May 2, 2022
* main: (31 commits)
  reduce noise of log output (#976)
  add version info and remove double config call (#977)
  Rename syft-id to package-id (#970)
  update to cyclonedx-go 0.5.2 (#971)
  refactor command package to remove globals and add dependency injection
  fix: #953 Derive language from pURL - https://github.com/anchore/syft… (#957)
  Fix typo in CPE-parsing error (#966)
  Preserve syft IDs on SBOM decode (#963)
  Update GitHub format package_url and correlator (#961)
  Ensure SPDXIDs are valid (#955)
  Auto-PR needs to run go mod tidy (#958)
  Add workflow for automatic PR for new stereoscope updates (#954)
  Minor readme update to correct format information (#948)
  Update spdx22json to only take uppercase checksum algorithm (#946)
  add additional vendors for springframework (#945)
  Add digest property to parent and nested java package metadata (#941)
  Update write permissions and log into ghcr.io for release (#942)
  Retry auth URL lookup without docker credentialhelper workaround (#939)
  Ensure that all cyclonedx components have bom-refs (#914)
  Additionally publish docker images to GHCR (#934)
  ...

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
rigzba21 pushed a commit to rigzba21/syft that referenced this pull request May 5, 2022
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants