bump goreleaser to v1.10.3 #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
|
Looking at the CI here now to help get this merged |
|
Wow, only one of the three broke though. I was figuring all of them would |
|
Also, likely need same bumps for grype. I'm out for a bit but can submit those when I get back unless someone else gets to it before then |
I'll get this fixes over in grype after looking at this one. |
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
wagoodman
approved these changes
Jul 28, 2022
wagoodman
reviewed
Jul 28, 2022
test/cli/utils_test.go
Outdated
| @@ -225,7 +225,11 @@ func getSyftBinaryLocationByOS(t testing.TB, goOS string) string { | |||
| // note: there is a subtle - vs _ difference between these versions | |||
| switch goOS { | |||
| case "darwin", "linux": | |||
| return path.Join(repoRoot(t), fmt.Sprintf("snapshot/%s-build_%s_%s/syft", goOS, goOS, runtime.GOARCH)) | |||
| archPath := runtime.GOARCH | |||
There was a problem hiding this comment.
nit: i feel it would be better to put the arch addition before the switch case in case we add more cases to the switch case in the future.
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
aiwantaozi
pushed a commit
to aiwantaozi/syft
that referenced
this pull request
Oct 20, 2022
Co-authored-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Co-authored-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Weston Steimel weston.steimel@anchore.com