Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch-distroless-ghcr #1110

Merged
merged 9 commits into from Jul 20, 2022
Merged

patch-distroless-ghcr #1110

merged 9 commits into from Jul 20, 2022

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Jul 20, 2022

Small manifest patch to make sure we're pulling from the correct images

Signed-off-by: Christopher Phillips christopher.phillips@anchore.com

spiffcs and others added 9 commits July 19, 2022 12:57
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    16.7ms ± 2%    11.6ms ± 1%  -30.52%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.93ms ±11%    1.31ms ± 3%  -32.30%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.68ms ± 2%    3.37ms ± 1%  -27.92%  (p=0.016 n=5+4)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.47ms ± 2%    1.08ms ± 2%  -26.30%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2        1.03ms ± 4%    0.74ms ± 1%  -27.94%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.24ms ± 1%    0.87ms ± 2%  -29.92%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.83ms ± 1%    1.31ms ± 4%  -28.03%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      20.3ms ± 3%    14.6ms ± 1%  -27.95%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.95ms ± 4%    1.30ms ± 2%  -32.97%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          3.18µs ± 7%    2.24µs ± 3%  -29.60%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               2.04ms ± 2%    1.38ms ± 2%  -32.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                   1.01ms ± 3%    0.69ms ± 1%  -31.91%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             945kB ± 0%     945kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     214kB ± 0%     214kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%     ~     (p=0.889 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      301kB ± 0%     301kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                369kB ± 0%     369kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%     ~     (p=0.397 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=0.484 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.25k ± 0%     4.25k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             16.6k ± 0%     16.6k ± 0%     ~     (p=0.889 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.53k ± 0%     5.54k ± 0%     ~     (p=0.079 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.60k ± 0%     4.60k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      8.10k ± 0%     8.10k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.794 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.43k ± 0%     5.43k ± 0%     ~     (p=0.444 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.27k ± 0%     7.27k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.59k ± 0%     3.59k ± 0%     ~     (all equal)

@spiffcs spiffcs changed the title move from scratch to distroless base patch-distroless-ghcr Jul 20, 2022
@spiffcs spiffcs requested a review from a team July 20, 2022 18:58
@spiffcs spiffcs merged commit 5dc729b into main Jul 20, 2022
@spiffcs spiffcs deleted the distroless-patch branch July 20, 2022 20:51
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants