Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update help formatting #1105

Merged
merged 1 commit into from Jul 19, 2022
Merged

update help formatting #1105

merged 1 commit into from Jul 19, 2022

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Jul 19, 2022

The latest release introduced a change where the help formatting was askew.

Before:
Screen Shot 2022-07-19 at 10 22 41 AM

After:
Screen Shot 2022-07-19 at 10 22 32 AM

Signed-off-by: Christopher Phillips christopher.phillips@anchore.com

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs enabled auto-merge (squash) July 19, 2022 14:26
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    14.8ms ±27%    11.2ms ± 1%  -24.30%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.61ms ± 5%    1.34ms ± 7%  -17.26%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.06ms ± 6%    3.30ms ± 2%  -18.77%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.28ms ±13%    1.04ms ± 1%  -18.54%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         897µs ± 1%     726µs ± 1%  -19.02%  (p=0.016 n=4+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.07ms ± 6%    0.85ms ± 0%  -20.24%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.47ms ± 5%    1.24ms ± 0%  -15.38%  (p=0.016 n=5+4)
ImagePackageCatalogers/java-cataloger-2                      16.1ms ± 6%    14.6ms ± 1%   -9.32%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.42ms ±23%    1.24ms ± 2%  -12.66%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          3.20µs ± 3%    2.17µs ± 3%  -32.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.94ms ± 3%    1.33ms ± 1%  -31.39%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    994µs ± 5%     674µs ± 1%  -32.19%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%     ~     (p=0.341 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             945kB ± 0%     945kB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     214kB ± 0%     214kB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      301kB ± 0%     301kB ± 0%   -0.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                369kB ± 0%     369kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%     ~     (p=0.452 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=0.095 n=5+4)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.25k ± 0%     4.25k ± 0%     ~     (p=0.167 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             16.6k ± 0%     16.6k ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.53k ± 0%     5.54k ± 0%   +0.02%  (p=0.029 n=4+4)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.60k ± 0%     4.60k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      8.10k ± 0%     8.10k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.43k ± 0%     5.43k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.27k ± 0%     7.27k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.59k ± 0%     3.59k ± 0%     ~     (all equal)

@spiffcs spiffcs merged commit 571de36 into main Jul 19, 2022
@spiffcs spiffcs deleted the help-formatting branch July 19, 2022 14:46
spiffcs added a commit to mayurwaghmode/syft that referenced this pull request Jul 20, 2022
* main:
  add distroless debug image to published release (anchore#1106)
  update help formatting (anchore#1105)
  feat: implement haskell support (anchore#1096)
  Add the -r argument for gnu xargs (anchore#1103)
  fix: -o output option to include formats (anchore#1102)

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs added a commit to mayurwaghmode/syft that referenced this pull request Jul 20, 2022
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs added a commit that referenced this pull request Jul 20, 2022
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants