Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moves go-rpmdb to latest; libc => v1.16.7 #1098

Merged
merged 1 commit into from Jul 12, 2022
Merged

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Jul 12, 2022

See #1097 for context:

Users were unable to build on certain architectures because the library usage for libc was on an older version. This PR bumps the root library knqyf263/go-rpmdb consuming libc which in turn:
upgraded modernc.org/libc v1.14.1 => v1.16.7

Signed-off-by: Christopher Phillips christopher.phillips@anchore.com

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs linked an issue Jul 12, 2022 that may be closed by this pull request
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    12.4ms ± 5%    11.3ms ± 2%   -8.78%  (p=0.016 n=5+4)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.47ms ±11%    1.28ms ± 1%  -12.86%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.49ms ± 4%    3.28ms ± 2%   -5.79%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.15ms ± 3%    1.03ms ± 0%  -10.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         817µs ± 7%     722µs ± 0%  -11.62%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     994µs ± 5%     846µs ± 0%  -14.92%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.35ms ± 2%    1.22ms ± 0%   -9.44%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      15.6ms ± 2%    14.4ms ± 0%   -7.98%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.32ms ± 3%    1.22ms ± 1%   -7.37%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.34µs ± 1%    2.14µs ± 1%   -8.38%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.44ms ± 0%    1.34ms ± 0%   -6.85%  (p=0.016 n=4+5)
ImagePackageCatalogers/portage-cataloger-2                    776µs ± 3%     662µs ± 0%  -14.73%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%   -0.07%  (p=0.016 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             945kB ± 0%     944kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     214kB ± 0%     214kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      301kB ± 0%     301kB ± 0%   +0.25%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%   +0.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                369kB ± 0%     369kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%     ~     (p=0.222 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=0.079 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.25k ± 0%     4.25k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             16.6k ± 0%     16.6k ± 0%     ~     (p=0.135 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.53k ± 0%     5.53k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.60k ± 0%     4.60k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      8.10k ± 0%     8.10k ± 0%   +0.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.43k ± 0%     5.43k ± 0%     ~     (all equal)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.27k ± 0%     7.27k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.59k ± 0%     3.59k ± 0%     ~     (p=0.556 n=4+5)

@spiffcs spiffcs merged commit 64b4852 into main Jul 12, 2022
@spiffcs spiffcs deleted the ppc64le-libc-upgrade branch July 12, 2022 14:30
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unable to build binary on ppc64le architecture
2 participants