update AltRpmDbGlob with comment and context

[spiffcs]

In the initial review, @wagoodman wanted to add a comment to clarify this addition.

The PR was merged before that feedback could be addressed.

This PR updates the new code with the suggested changes.

Signed-off-by: Christopher Phillips christopher.phillips@anchore.com

[github-actions]

Benchmark Test Results

Benchmark results from the latest changes vs base branch

name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    9.54ms ± 6%   14.56ms ± 0%  +52.58%  (p=0.016 n=5+4)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               943µs ± 4%    1698µs ±11%  +80.11%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            2.43ms ± 0%    3.94ms ± 1%  +62.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     801µs ±14%    1289µs ± 1%  +60.97%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         514µs ± 0%     922µs ± 9%  +79.26%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     627µs ± 3%    1084µs ± 2%  +72.88%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      865µs ± 1%    1503µs ± 3%  +73.80%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      10.6ms ± 1%    17.5ms ± 1%  +64.35%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.08ms ±15%    1.48ms ± 3%  +37.49%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.85µs ± 1%    2.76µs ± 3%  +49.39%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.03ms ± 0%    1.68ms ± 1%  +63.23%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.25MB ± 0%    5.25MB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               193kB ± 0%     193kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             918kB ± 0%     917kB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     205kB ± 0%     205kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         149kB ± 0%     149kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     194kB ± 0%     194kB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      283kB ± 0%     282kB ± 0%   -0.23%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.36MB ± 0%    3.36MB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.24MB ± 0%    1.24MB ± 0%   -0.05%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                361kB ± 0%     360kB ± 0%   -0.07%  (p=0.016 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.5k ± 0%     85.5k ± 0%     ~     (p=0.571 n=4+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               3.98k ± 0%     3.98k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             15.7k ± 0%     15.7k ± 0%     ~     (p=0.238 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.26k ± 0%     5.26k ± 0%     ~     (p=0.643 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.03k ± 0%     3.03k ± 0%     ~     (p=0.238 n=4+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.32k ± 0%     4.32k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      7.53k ± 0%     7.53k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       55.0k ± 0%     55.0k ± 0%     ~     (p=0.579 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.15k ± 0%     5.15k ± 0%     ~     (p=0.333 n=5+4)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                6.99k ± 0%     6.99k ± 0%     ~     (all equal)