Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for cocoapods (Swift/Objective-C) #1081

Merged
merged 4 commits into from Jul 11, 2022

Conversation

cpendery
Copy link
Contributor

@cpendery cpendery commented Jul 1, 2022

馃摑 Description

Add support for Cocoapods lock files to produce sbom artifacts. I defaulted to the Swift language everywhere, though Cocoapods supports Objective-C, so I could use pointers on this similar to the BeamVM pr #1073

Related: anchore/grype#815

Signed-off-by: cpendery <cpendery@vt.edu>
Signed-off-by: cpendery <cpendery@vt.edu>
@spiffcs
Copy link
Contributor

spiffcs commented Jul 6, 2022

@cpendery I'm going to grab this one and start updating the conflicts - then I'll get a review and hopefully we should be good to go to get this merged.

@cpendery
Copy link
Contributor Author

cpendery commented Jul 6, 2022

@cpendery I'm going to grab this one and start updating the conflicts - then I'll get a review and hopefully we should be good to go to get this merged.

Thank you!! This one does run into the same issue with Hex that Cocoapods supports both Swift and ObjectiveC, so I've just used Swift everywhere for the language. I'll update the purl-spec pr later today with some information on identifying source languages

@spiffcs
Copy link
Contributor

spiffcs commented Jul 6, 2022

@cpendery I'm going to grab this one and start updating the conflicts - then I'll get a review and hopefully we should be good to go to get this merged.

Thank you!! This one does run into the same issue with Hex that Cocoapods supports both Swift and ObjectiveC, so I've just used Swift everywhere for the language. I'll update the purl-spec pr later today with some information on identifying source languages

That's cool. If it looks like it's going to take a while to evolve the specification on your submission to them then I think we can find ways to keep the detail of what language is captured on our internal model. I'll ask @wagoodman if he has any preferences here.

@spiffcs
Copy link
Contributor

spiffcs commented Jul 11, 2022

Approving and merging this now with the caveat that there is some work to be done on the PURL side for language identification.

@spiffcs spiffcs merged commit 470b130 into anchore:main Jul 11, 2022
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants