change default behavior so action fails on medium (and higher) severities #86
Conversation
alfredodeza
force-pushed
the
issue-83
branch
4 times, most recently
from
650afb7
to
7dad812
Compare
action.yml
Outdated
| @@ -15,9 +15,9 @@ inputs: | |||
| required: false | |||
| default: 'false' | |||
| fail-build: | |||
| description: 'Set to any value to cause build to fail upon failed anchore policy evaluation' | |||
| description: 'Set to false to avoid failing based on severity level. Default is to fail when severity threshold is met' | |||
There was a problem hiding this comment.
I'd suggest being consistent with what we call the severity threshold. Here was say "severity threshold", but it looks like elsewhere in this action's settings we say "severity-cutoff"
There was a problem hiding this comment.
@luhring I went to make the change, but the thing is that severity-cutoff is the key, not a wording. So I could make everything refer to that key instead. Is that what you were thinking too?
That is: the severity threshold is the value for the severity-cutoff configuration key
There was a problem hiding this comment.
@alfredodeza I think I'm missing something - perhaps a 3 min zoom session would set me straight 😄
There was a problem hiding this comment.
I've updated this to use severity-cutoff instead of "severity threshold"
Signed-off-by: Alfredo Deza <adeza@anchore.com>
Signed-off-by: Alfredo Deza <adeza@anchore.com>
Signed-off-by: Alfredo Deza <adeza@anchore.com>
Signed-off-by: Alfredo Deza <adeza@anchore.com>
Signed-off-by: Alfredo Deza <adeza@anchore.com>
Fixes issue #83