Allow type "file:..." to enable creation of SBOMs from tar and other package formats

[malt3]

Signed-off-by: Malte Poll mp@edgeless.systems

[kzantow]

Hi @malt3, thanks for the submission! I think to be consistent we should probably add a file parameter, which is mutually exclusive to image and path instead of having the path double as both dir and file. Would this work for you?

[malt3]

Sure thing. It sounds a little bit confusing to have path which resolves to dir: and file which resolves to file: but renaming the existing parameter is probably even worse as it is breaking change.
What do you think about keeping path -> dir: for backwards compat and adding both file -> file: and dir -> dir: as parameters?
Just a suggestion. I can implement this any way you like :)

[kzantow]

@malt3 I think keeping path -> dir: and adding a file -> file: is the right thing to do for now. NOTE: these are syft conventions that haven't actually been set it stone, so we chose path. I agree it seems perhaps a bit ambiguous, but to avoid breaking changes, I suggest just adding the file option (and, of course updating the documentation/action config/etc. to reflect this).

[kzantow]

@malt3 thanks for the contribution -- this looks good, I just need to get a successful run of the tests. I'm not sure why they haven't run yet... It appears GH may be having some issues with actions at the moment. I'll try to get them kicked off later today.

[felickz]

This PR was pushed with 0.13.0 but not seeing the file property being observed: #383 (comment)