Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SBOM format handling #235

Merged
merged 5 commits into from Apr 6, 2022

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Apr 4, 2022

Since we can now integrate between Syft and Grype using any of the primary SBOM formats, improve handling and documentation of them, namely adding cyclonedx-json and using better file suffixes by default.

This fixes #174

Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow requested a review from a team April 4, 2022 16:37
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow requested a review from wagoodman April 4, 2022 19:14
Copy link

@jonasagx jonasagx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Q: would it be worth it to test getArtifactName?

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow requested a review from jonasagx April 6, 2022 19:38
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow merged commit 946c3bf into anchore:main Apr 6, 2022
@kzantow kzantow deleted the update-cyclonedx-formats branch April 6, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update list of supported outputs
3 participants