Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build one dist bundle with a flag for sub-actions #232

Open
kzantow opened this issue Apr 4, 2022 · 0 comments
Open

Only build one dist bundle with a flag for sub-actions #232

kzantow opened this issue Apr 4, 2022 · 0 comments

Comments

@kzantow
Copy link
Contributor

kzantow commented Apr 4, 2022

Due to limitations of ncc, it is not possible to code split the bundles generated in dist/ but instead we are duplicating all the code in 3 separate bundles for the sub-actions. This is not particularly fast when committing and requires users to download a small amount more every time the action is used. The other option we have is just build a single bundle and switch based on some incoming parameter; this was done in the scan-action and works well. I think it is a preferable approach we should apply here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant