Detect when a user specifies an empty SBOM #695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #693.
A related PR fixes the underlying panic in the Syft library, but that PR isn't strictly necessary to fix #693 now that the "empty SBOM" case is detected earlier in execution.
Additionally, I noticed that an unrelated test was failing locally:
TestGetter_GetFile/client_doesn't_trust_server's_CA
. This test appeared to be failing only on macOS environments, and only when using Go 1.18. This PR makes an adjustment to the test logic to avoid this new failure. (For more information, see https://go.dev/doc/go1.18#minor_library_changes, in the section "crypto/x509".)