Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump strset version to fix 386 builds #689

Merged
merged 1 commit into from Mar 23, 2022
Merged

Bump strset version to fix 386 builds #689

merged 1 commit into from Mar 23, 2022

Conversation

wagoodman
Copy link
Contributor

Pull in fix from scylladb/go-set@cc7b207 to prevent compile issues on 32 bit architectures:

$ GOOS=linux GOARCH=386 go build  -o /tmp/out examples/basic.go
# github.com/scylladb/go-set/strset
../../.gvm/pkgsets/go1.18/global/pkg/mod/github.com/scylladb/go-set@v1.0.2/strset/strset.go:248:13: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in assignment (overflows)
../../.gvm/pkgsets/go1.18/global/pkg/mod/github.com/scylladb/go-set@v1.0.2/strset/strset.go:255:16: math.MaxInt64 (untyped int constant 9223372036854775807) overflows int

$ go get -d github.com/scylladb/go-set@master
go: downloading github.com/scylladb/go-set v1.0.3-0.20200225121959-cc7b2070d91e
go: upgraded github.com/scylladb/go-set v1.0.2 => v1.0.3-0.20200225121959-cc7b2070d91e

$ GOOS=linux GOARCH=386 go build  -o /tmp/out examples/basic.go
# success!

@wagoodman wagoodman requested a review from a team March 23, 2022 16:23
@wagoodman wagoodman self-assigned this Mar 23, 2022
@wagoodman wagoodman added the bug Something isn't working label Mar 23, 2022
Copy link
Contributor

@jonasagx jonasagx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tests validating this?

@wagoodman
Copy link
Contributor Author

wagoodman commented Mar 23, 2022

@jonasagx no, there isn't. We don't officially support 32bit builds yet, when we do, we will have a test in the form of a snapshot build (which we already run on all PRs). When we're ready to support 32 bit then simply expanding the build architecture section for linux builds in the .goreleaser.yaml will do the trick.

@jonasagx
Copy link
Contributor

Nice! GoReleaser is awesome 😎

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman enabled auto-merge (squash) March 23, 2022 18:24
@wagoodman wagoodman merged commit 9fc6fb8 into main Mar 23, 2022
@wagoodman wagoodman deleted the bump-strset branch March 23, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants