Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct go.mod to enforce go 1.18 #685

Merged
merged 1 commit into from Mar 22, 2022
Merged

Conversation

06kellyjac
Copy link
Contributor

Same vein as anchore/syft#897

Since grype now depends on debug/buildinfo go 1.18 is required to build grype and as such go.mod needs updating

Go 1.18 Release Notes
New debug/buildinfo package

https://tip.golang.org/doc/go1.18

Signed-off-by: 06kellyjac jack@control-plane.io

cc: @luhring

Since grype now depends on debug/buildinfo go 1.18 is required to build
grype and as such go.mod needs updating

Signed-off-by: 06kellyjac <jack@control-plane.io>
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't understand exactly why 1,074 lines of go.sum are being removed, but I can reproduce the same effect when I make this change locally. Between that, and CI passing, this is good enough for me!

🎉

@luhring luhring merged commit d40fb77 into anchore:main Mar 22, 2022
@06kellyjac
Copy link
Contributor Author

It seems like 1.18 can be a bit smarter when pulling in transitive deps?

But yeah it was all from the go mod tidy

@06kellyjac 06kellyjac deleted the correct_go.mod branch March 22, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants