Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize release assets and refactor install.sh #630

Merged
merged 6 commits into from Feb 11, 2022
Merged

Normalize release assets and refactor install.sh #630

merged 6 commits into from Feb 11, 2022

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Feb 11, 2022 •
edited

This brings grype up to parity with syft from anchore/syft#765 and anchore/syft#789 (and a few others, but those are the main PRs).

The same benefits from those PRs apply here:

  • today the release assets do not match the snapshot assets (the signing process creates new assets unnecessarily), making it difficult to test the install.sh against a snapshot. This PR makes the release assets the same as the snapshot assets.
  • install.sh today is not under test, this PR puts them under test such that changes to the goreleaser builds can be checked against a branch snapshot build to ensure that they will function as expected for all assets generated.

Fixes anchore/project-toolbox#113

@wagoodman wagoodman requested a review from a team February 11, 2022 14:42
@wagoodman wagoodman self-assigned this Feb 11, 2022
@wagoodman wagoodman force-pushed the refactor-release-and-install branch 2 times, most recently from b9771de to 6edcc2b Compare February 11, 2022 16:06
@wagoodman
refactor release to keep snapshot assets in parity with release assets
8c4f01d 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
refactor install.sh and put under test
0175929 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
tidy go.sum
fbe6036 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
add mac acceptance test to github actions workflow
17ba5de 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
rm use of goreleaser in cli tests
cbc2407 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman marked this pull request as ready for review February 11, 2022 16:18
luhring
luhring approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving w/ the assumption that this work lines up with the work done in Syft — so let me know if that's a flawed assumption! 😀

@wagoodman
Copy link
Contributor Author

wagoodman commented Feb 11, 2022 •
edited

not flawed @luhring , lots of copy-paste 👍 ... the one exception is the rebase with the go 1.17 bump (which looks to be causing some problems)

@wagoodman
go mod tidy with go 1.17
fa301d3 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman enabled auto-merge (squash) February 11, 2022 19:03
@wagoodman wagoodman merged commit 5aa8533 into main Feb 11, 2022
@wagoodman wagoodman deleted the refactor-release-and-install branch February 11, 2022 19:24
suzuki-shunsuke added a commit to aquaproj/aqua-registry that referenced this pull request Feb 15, 2022
@suzuki-shunsuke
feat: grype asset format was changed from v0.33.0
d550dbd 
anchore/grype#630
renovate bot pushed a commit to aquaproj/aqua-registry that referenced this pull request Feb 15, 2022
@suzuki-shunsuke @renovate
feat: grype asset format was changed from v0.33.0
7eaf5b5 
anchore/grype#630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhring luhring luhring approved these changes

Assignees

@wagoodman wagoodman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wagoodman @luhring