Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily this PR adds the ability to merge two matches that have the same vulnerability-package pair, but the matching details may be different (what was searched by, what attribute was matched on, the matcher that found the result, etc). In the case of merging the list of
match.Details
is combined and one match object is kept.This PR additionally makes the following adjustments:
match.NewMatches()
constructor to take an initial variadic list of matchesmatchers.common
package tosearch
which makes usage less awkward and more semantically correct (the matchers use search utilities, not common utilities... e.g.common.FindMatchesByPackageLanguage(...)
-->search.ByPackageLanguage(...)
)search.ByCriteria
to reduce the code for each matcher object. This turns the old approach:into:
This work is loosely related to #395