Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table output removes duplicates despite vulnerability being in different projects #1327

Open
jneate opened this issue May 31, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jneate
Copy link
Contributor

jneate commented May 31, 2023

Accidentally discovered running grype against a directory with two components in it, that have the same vulnerability results in Grype only displaying the one vulnerability in the table despite it appearing twice in two different files/locations.

image

Vuln ID: GHSA-36p3-wjmg-h94x

As you can see, in the JSON output the difference is the location but in the table output, the location is not present and therefore the removeDuplicates function https://github.com/anchore/grype/blob/main/grype/presenter/table/presenter.go#L83 removes it as a duplicate.

image

I think this could inadvertently be fixed by #1275 but thought best to raise it anyway.

@jneate jneate added the bug Something isn't working label May 31, 2023
@tgerla
Copy link
Contributor

tgerla commented Aug 17, 2023

Thanks @jneate, we are discussing this. Would it make sense if we instead of removing the duplicate put a "(2)" indicator after the vulnerability ID, so that you could immediately see you have two instances of that vulnerability?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants