Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit range is including incorrect number of commits #74

Open
spiffcs opened this issue Mar 3, 2023 · 0 comments · May be fixed by #75
Open

Commit range is including incorrect number of commits #74

spiffcs opened this issue Mar 3, 2023 · 0 comments · May be fixed by #75
Labels
bug Something isn't working

Comments

@spiffcs
Copy link
Contributor

spiffcs commented Mar 3, 2023

What happened:
Chronical is identifying the correct commit range to search:

[0000] TRACE searching commit range since=04a55885ee162ec00548ec39df68c5b62cf213b5 until=1d013affc27ff04c45411183443def13ca136088

➜  grype git:(pipeline-parity) ✗ git rev-list --ancestry-path 04a5588..1d013a
1d013affc27ff04c45411183443def13ca136088
7c7afa27d3ec9ee550c13b5b81daa53e29ae0a87
adad97628e7adfc3ad690ecefe8643285d2d1b06

However it's computing 862 commits to examine rather than the 3 seen above

DEBUG release comprised of 862 commits

What you expected to happen:
I expected 3 commits to appear in the release

How to reproduce it (as minimally and precisely as possible):
There is an open grype branch called pipeline-parity if you pull from head and run make changelog this can be reproduced

Anything else we need to know?:

Environment:
osx

  • Output of chronicle version:
Application:   chronicle
Version:       0.6.0
BuildDate:     2023-02-08T16:24:20Z
GitCommit:     cfbdb0791a8aaaf00b912e6725ea84d40ed0dc30
GitTreeState:  clean
Platform:      darwin/amd64
GoVersion:     go1.17.13
Compiler:      gc
@spiffcs spiffcs added the bug Something isn't working label Mar 3, 2023
@spiffcs spiffcs linked a pull request Mar 3, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect commit range anchore/chronicle
1 participant
@spiffcs