Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example using Tokio runtime #362

Merged
merged 3 commits into from Mar 6, 2022
Merged

Add an example using Tokio runtime #362

merged 3 commits into from Mar 6, 2022

Conversation

ndelvalle
Copy link
Contributor

No description provided.

@Keruspe
Copy link
Collaborator

Keruspe commented Mar 5, 2022

Thanks a lot!

Can you drop the crate, moving the dependencies to the dev-dependencies of lapin, and moving the source file to examples/tokio.rs please?

This way it will be at the same place as the others, but most importantly it will be checked by CI.

It would be awesome if you could also add a note saying that for now the reactor is only available for unix.

Thanks again

@ndelvalle
Copy link
Contributor Author

Thanks a lot!

Can you drop the crate, moving the dependencies to the dev-dependencies of lapin, and moving the source file to examples/tokio.rs please?

This way it will be at the same place as the others, but most importantly it will be checked by CI.

It would be awesome if you could also add a note saying that for now the reactor is only available for unix.

Thanks again

I think I addressed all your comments, let me know if it is good to go 👍🏻

@Keruspe
Copy link
Collaborator

Keruspe commented Mar 6, 2022

Perfect, thanks!

@Keruspe Keruspe merged commit 4911142 into amqp-rs:main Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants