android: Use ndk-context instead of ndk-glue to access JVM #52
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes webbrowser-rs more compatible with different Android application frameworks by not imposing that applications must use ndk-glue. This also bumps the `jni` dependency to 0.20 and uses the `JObject::from_raw` API. Fixes: amodm#51
amodm
reviewed
Oct 31, 2022
|
Thanks for the clarification, @rib, and for making the Android code for this library more stable. |
|
This is now out as v0.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes webbrowser-rs more compatible with different Android application frameworks by not imposing that applications must use ndk-glue.
This also bumps the
jnidependency to 0.20 and uses theJObject::from_rawAPI.Fixes: #51