Encrypted Storage Bugfixes #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi, using a new key if the existing key did not exist means the data encrypted with older key will not exist anymore. It will be wiped and replaced with new data. I am not sure if it's a good solution yet to immediately create a new key & and a new storage instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues I've seen in a production app with encrypted storage.
This moves the
initWithEncryptionWithoutSecureStoragecall higher up because the app was crashing when trying to access secure storage on an instance that did not use secure storage. It was going down theif (IDStore.exists(id))path which ultimately tried to encrypt with a key stored in secure storage even though it was configured to not use secure storage. This fixes #265This also moves the
initWithEncryptionUsingNewKeycall higher up because the app got into a bad state where theIDStore.exists(id)call was returning true but themmkvJsiModule.getSecureKeycall was returning nothing. I'm not sure how it got into the bad state but it may be related to the problem that was fixed by 0.8.0. If the secure key does not exist, it should use a new key instead of continually trying to use the nonexistent key.