Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flow >= v0.71 on Windows #163

Merged
merged 1 commit into from Feb 24, 2019
Merged

Conversation

nwoltman
Copy link
Collaborator

Starting in Flow v0.71, Flow will hang forever on Windows when a Flow server is started with flow check-contents (see facebook/flow#6834).

This fix prevents Flow from hanging by manually starting the Flow server with flow start before the flow check-contents call.

Fixes #156

Starting in Flow v0.71, Flow will hang forever on Windows when a Flow server is started with `flow check-contents`. This fix prevents Flow from hanging by manually starting the Flow server with `flow start` before the `flow check-contents` call.
@amilajack
Copy link
Owner

Yayyy this fixed our azure pipelines CI! Thanks for this

@amilajack amilajack merged commit 6388bf5 into amilajack:master Feb 24, 2019
@amilajack
Copy link
Owner

Published this to eslint-plugin-flowtype-errors@next

@nwoltman nwoltman deleted the fix-windows branch February 24, 2019 03:30
@nwoltman
Copy link
Collaborator Author

I've been testing eslint-plugin-flowtype-errors@next in a medium-sized project of mine and everything seems to be working well.

@amilajack
Copy link
Owner

Awesome! I'll publish 4.0.0 now after updating changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hangs during webpack build
2 participants