Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New config lookup #125

Merged
merged 5 commits into from Aug 29, 2018
Merged

New config lookup #125

merged 5 commits into from Aug 29, 2018

Conversation

jdmota
Copy link
Collaborator

@jdmota jdmota commented Jul 30, 2018

As discussed in #124, I'm proposing a change in the way we look for .flowconfig, to allow for monorepo folder structure.

Breaking change

  • Removed flowDir setting
  • Starting on each file, look upwards for a .flowconfig file. That becames the root.

Other changes

  • Refactoring and ran prettier
  • Removed spec-win script (tested on Windows that spec works just fine)
  • Use execa instead of cross-spawn in tests (returns a promise allowing for async tests)

TODO

  • Optimize lookup?
  • Update README
  • Update CHANGELOG

Notes

@amilajack amilajack merged commit 7015fc7 into amilajack:master Aug 29, 2018
@nwoltman nwoltman mentioned this pull request Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants