Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support safari TP as a target #285

Merged
merged 5 commits into from
Jan 21, 2020
Merged

fix: support safari TP as a target #285

merged 5 commits into from
Jan 21, 2020

Conversation

eligao
Copy link
Contributor

@eligao eligao commented Jan 21, 2020 •
edited

closes #284

ljharb
ljharb approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@ljharb ljharb requested a review from amilajack January 21, 2020 21:04
amilajack
amilajack approved these changes Jan 21, 2020
View reviewed changes
Copy link
Owner

@amilajack amilajack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@amilajack amilajack merged commit 9735aa4 into amilajack:master Jan 21, 2020
@amilajack
Copy link
Owner

amilajack commented Jan 21, 2020 •
edited

Published these changes to eslint-plugin-compat@next. Please let me know if these changes work for you and I will cut a new release for 3.5.1.

@eligao
Copy link
Contributor Author

eligao commented Jan 22, 2020

Published these changes to eslint-plugin-compat@next. Please let me know if these changes work for you and I will cut a new release for 3.5.1.

I tested locally on my previously bugged project by using eslint-plugin-compat@3.5.1-0 and forced Safari TP in .browserslistrc, and the lint passed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@amilajack amilajack amilajack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Invalid Version: null
3 participants
@eligao @amilajack @ljharb