Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Misleading error message when One App is killed #599

Closed
smackfu opened this issue Jan 16, 2024 · 1 comment
Closed

Misleading error message when One App is killed #599

smackfu opened this issue Jan 16, 2024 · 1 comment

Comments

@smackfu
Copy link
Member

smackfu commented Jan 16, 2024

馃悶 Bug Report

Describe the bug

When one-app is killed by SIGKILL, a message is printed that says "Error: Error running docker. Are you sure you have it installed?" This error message is not useful.

To Reproduce

Start one-app via one-app-runner, then stop the container.

...
error: still running after 10s, forcibly shutting down
error: shutting down, forcibly stopping node
<mydir>/node_modules/@americanexpress/one-app-runner/src/startApp.js:258
    throw new Error(
          ^

Error: Error running docker. Are you sure you have it installed? For installation and setup details see https://www.docker.com/products/docker-desktop
    at startApp (<mydir>/node_modules/@americanexpress/one-app-runner/src/startApp.js:258:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  [cause]: 137
}

Expected behavior

There is no need for an error to be printed here.

Copy link

This issue is stale because it has been open 30 days with no activity.

@10xLaCroixDrinker 10xLaCroixDrinker closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants