Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

one-app-bundler: eslint-loader is deprecated in favor of eslint-webpack-plugin #579

Closed
aorinevo opened this issue Oct 7, 2023 · 3 comments

Comments

@aorinevo
Copy link
Member

aorinevo commented Oct 7, 2023

馃挕 Feature request

Deprecate eslint-loader in favor of eslint-webpack-plugin.

A clear and concise description of what you want and what your use case is.

Example

Please include a basic code example of the new feature. Skip this section if not applicable.

My team is undertaking dependency management and as part of that, we are attempting to upgrade to latest eslint. In that process we came to identify that one-app-bundler relies on eslint-loader 4.0.2 which is incompatible with eslint ^8. This is blocking our adoption of eslint v8.

A clear and concise description of what you want to happen.

Replace eslint-loader package with its successor, eslint-webpack-plugin.

A clear and concise description of any alternative solutions or features you've considered.

One alternative is to force install eslint-loader at the root of our project, however, while this will allow for successful install it creates other issues in the build process. Other than that, I do not know of any tractable alternate solutions.

Copy link

github-actions bot commented Nov 7, 2023

This issue is stale because it has been open 30 days with no activity.

@JAdshead
Copy link
Contributor

This is already underway in #568 - https://github.com/americanexpress/one-app-cli/pull/568/files/888f13def5b817014155275b7f36a6ec56bf35ec..aa2c5a5ad7f279996b6ab733f777a43ccba0eb8b

Unfortunately when the migration was previously done it resulted in some unexpected breaking changes and had to be reverted.

Copy link

This issue is stale because it has been open 30 days with no activity.

@10xLaCroixDrinker 10xLaCroixDrinker closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants