chore(deps): bump chalk from ^1.1.3 to ^4.0.0
#310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [chalk][1] from `^1.1.3` to `^4.0.0`. - [Release notes](https://github.com/chalk/chalk/releases) - [v2.0.0](https://github.com/chalk/chalk/releases/tag/v2.0.0) - [v3.0.0](https://github.com/chalk/chalk/releases/tag/v3.0.0) - [v4.0.0](https://github.com/chalk/chalk/releases/tag/v4.0.0) - [Commits](chalk/chalk@v1.1.3...v4.0.0) Chalk's major changes were: - Minimum required Node version is Node v10 (v4) - `chalk.constructor` has been replaced with `chalk.Instance` (v3) - `chalk.enabled` has been replaced with `chalk.level` (v3) Jest v28 uses Chalk v4 as a dependency, so using the same version in jest-image-snapshot will mean users only need to download one version of chalk. [1]: https://www.npmjs.com/package/chalk
aloisklink
commented
Aug 31, 2022
Comment on lines
+2629
to
+2633
| "chalk": { | ||
| "version": "1.1.3", | ||
| "resolved": "https://registry.npmjs.org/chalk/-/chalk-1.1.3.tgz", | ||
| "integrity": "sha512-U3lRVLMSlsCfjqYPbLyVv11M9CPW4I728d6TCKMAOJueEeB9/8o+eSsMnxPJD+Q+K909sdESg7C+tIkoH6on1A==", | ||
| "dev": true, |
There was a problem hiding this comment.
chalk v1.1.3 is now only required as a "dev" dependency, and should completely disappear from your package-lock.json file once you update eslint-config-amex to a newer version.
Comment on lines
-39
to
-43
| const ChalkMock = () => ({ | ||
| bold: { | ||
| red: input => input, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This doesn't seem to do anything, so I've removed it.
I'm guessing that maybe this code was used in earlier tests but is no longer needed.
10xLaCroixDrinker
approved these changes
Sep 1, 2022
bishnubista
approved these changes
Sep 2, 2022
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps chalk from
^1.1.3to^4.0.0.Chalk's major changes were:
chalk.constructorhas been replaced withchalk.Instance(v3)chalk.enabledhas been replaced withchalk.level(v3)Motivation and Context
Jest v28 uses Chalk v4 as a dependency, so using the same version in jest-image-snapshot will mean users only need to download one version of chalk.
How Has This Been Tested?
jesttests pass.I've tried testing this branch on my own project (remark-mermaid-dataurl) using the following, and it works fine.
Additionally, my
package-lock.jsonfile lost 107 lines, so a bunch of packages were no longer needed.Types of Changes
Checklist:
[ ] My change requires a change to the documentation and I have updated the documentation accordingly.No change required.What is the Impact to Developers Using Jest-Image-Snapshot?
No major changes, except that their
package-lock.jsonfile should be slightly simpler, and theirnode_modulesfolder slightly smaller (assuming that they have no other packages that rely onchalkv1).