Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dist): remove images from install bundle #307

Merged
merged 1 commit into from Aug 25, 2022

Conversation

10xLaCroixDrinker
Copy link
Member

Description

fixes #294

Motivation and Context

smaller bundle => faster install => better DX

How Has This Been Tested?

Before:

$ npm pack
npm notice
npm notice 馃摝  jest-image-snapshot@5.1.0
npm notice === Tarball Contents ===
npm notice 148B    .editorconfig
npm notice 24B     .eslintrc.json
npm notice 7B      .gitattributes
npm notice 42B     .github/labeler.yml
npm notice 1.7kB   .github/pull_request_template.md
npm notice 679B    .github/workflows/health-check.yml
npm notice 234B    .github/workflows/pr-labeler.yml
npm notice 1.0kB   .github/workflows/release.yml
npm notice 702B    .github/workflows/stale.yml
npm notice 909B    .github/workflows/tests.yml
npm notice 6.7kB   CHANGELOG.md
npm notice 8.5kB   CODE_OF_CONDUCT.md
npm notice 79B     CODEOWNERS
npm notice 3.7kB   CONTRIBUTING.md
npm notice 10.3kB  LICENSE.txt
npm notice 16.5kB  README.md
npm notice 792B    commitlint.config.js
npm notice 949.2kB images/create-snapshot.gif
npm notice 1.7MB   images/fail-snapshot.gif
npm notice 316.6kB images/image-diff.png
npm notice 52.4kB  jest-image-snapshot.png
npm notice 2.7kB   package.json
npm notice 1.2kB   src/diff-process.js
npm notice 12.6kB  src/diff-snapshot.js
npm notice 2.0kB   src/image-composer.js
npm notice 9.3kB   src/index.js
npm notice 2.8kB   src/outdated-snapshot-reporter.js
npm notice === Tarball Details ===
npm notice name:          jest-image-snapshot
npm notice version:       5.1.0
npm notice filename:      jest-image-snapshot-5.1.0.tgz
npm notice package size:  2.8 MB
npm notice unpacked size: 3.1 MB
npm notice shasum:        857ef3cc50aa4e68c0ab05b4e71feea4709cc787
npm notice integrity:     sha512-ajrkvObIpZg5B[...]7QudsixvLDFAw==
npm notice total files:   27
npm notice
jest-image-snapshot-5.1.0.tgz

After:

$ npm pack
npm notice
npm notice 馃摝  jest-image-snapshot@5.1.0
npm notice === Tarball Contents ===
npm notice 148B   .editorconfig
npm notice 24B    .eslintrc.json
npm notice 7B     .gitattributes
npm notice 6.7kB  CHANGELOG.md
npm notice 8.5kB  CODE_OF_CONDUCT.md
npm notice 79B    CODEOWNERS
npm notice 3.7kB  CONTRIBUTING.md
npm notice 10.3kB LICENSE.txt
npm notice 16.7kB README.md
npm notice 792B   commitlint.config.js
npm notice 2.7kB  package.json
npm notice 1.2kB  src/diff-process.js
npm notice 12.6kB src/diff-snapshot.js
npm notice 2.0kB  src/image-composer.js
npm notice 9.3kB  src/index.js
npm notice 2.8kB  src/outdated-snapshot-reporter.js
npm notice === Tarball Details ===
npm notice name:          jest-image-snapshot
npm notice version:       5.1.0
npm notice filename:      jest-image-snapshot-5.1.0.tgz
npm notice package size:  25.5 kB
npm notice unpacked size: 77.5 kB
npm notice shasum:        5a921efe42b66c740e05a81dac02d130e716c964
npm notice integrity:     sha512-oVidbCRLDGbQP[...]G8s6Ataqwab8A==
npm notice total files:   16
npm notice
jest-image-snapshot-5.1.0.tgz

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Jest-Image-Snapshot?

Faster, lighter installs

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team August 25, 2022 14:40
@JAdshead JAdshead merged commit 6cfa90a into main Aug 25, 2022
@JAdshead JAdshead deleted the feature/smaller-install branch August 25, 2022 23:22
@oneamexbot
Copy link
Contributor

馃帀 This PR is included in version 5.1.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

goverdhan07 pushed a commit to goverdhan07/jest-image-snapshot that referenced this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce distribution size
4 participants