Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(diff-snapshot): make recievedDir optional #306

Merged
merged 1 commit into from Aug 25, 2022
Merged

fix(diff-snapshot): make recievedDir optional #306

merged 1 commit into from Aug 25, 2022

Conversation

10xLaCroixDrinker
Copy link
Member

Description

fixes #300

Motivation and Context

How Has This Been Tested?

Edited unit tests to include case missing recievedDir

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Jest-Image-Snapshot?

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team as a code owner August 25, 2022 12:11
@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team August 25, 2022 14:41
@JAdshead JAdshead merged commit cd4fa73 into main Aug 25, 2022
@JAdshead JAdshead deleted the feature/make-recieveddir-optional branch August 25, 2022 23:22
oneamexbot added a commit that referenced this pull request Aug 25, 2022
@oneamexbot
chore(release): 5.1.1 [skip ci]
1f4be75 
## [5.1.1](v5.1.0...v5.1.1) (2022-08-25)

### Bug Fixes

* **diff-snapshot:** make recievedDir optional ([#306](#306)) ([cd4fa73](cd4fa73)), closes [#300](#300)
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

goverdhan07 pushed a commit to goverdhan07/jest-image-snapshot that referenced this pull request Jul 23, 2023
@10xLaCroixDrinker
fix(diff-snapshot): make recievedDir optional (americanexpress#306)
c22696c 
fixes americanexpress#300
goverdhan07 pushed a commit to goverdhan07/jest-image-snapshot that referenced this pull request Jul 23, 2023
@oneamexbot
chore(release): 5.1.1 [skip ci]
b3cd311 
## [5.1.1](americanexpress/jest-image-snapshot@v5.1.0...v5.1.1) (2022-08-25)

### Bug Fixes

* **diff-snapshot:** make recievedDir optional ([americanexpress#306](americanexpress#306)) ([cd4fa73](americanexpress@cd4fa73)), closes [americanexpress#300](americanexpress#300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAdshead JAdshead JAdshead approved these changes

@giulianok giulianok giulianok approved these changes

Assignees
No one assigned
Labels
one-app-team-review-requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "path" argument must be of type string. Received undefined
4 participants
@10xLaCroixDrinker @oneamexbot @JAdshead @giulianok