feat: remove snap suffix if use custom identifier #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
10xLaCroixDrinker
previously approved these changes
Aug 25, 2022
kibala145
force-pushed
the
feature/custom-identifier-remove-snap-suffix
branch
from
6533e60
to
6a53043
Compare
|
Resolved conflicts locally and pushed with force so |
10xLaCroixDrinker
approved these changes
Aug 30, 2022
JAdshead
approved these changes
Aug 31, 2022
oneamexbot
added a commit
that referenced
this pull request
Aug 31, 2022
# [5.2.0](v5.1.1...v5.2.0) (2022-08-31) ### Features * remove snap suffix if use custom identifier ([#305](#305)) ([775ac0a](775ac0a))
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
Co-authored-by: Ivan Kibala <ivankibala@Ivans-MacBook-Air.local>
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
# [5.2.0](americanexpress/jest-image-snapshot@v5.1.1...v5.2.0) (2022-08-31) ### Features * remove snap suffix if use custom identifier ([americanexpress#305](americanexpress#305)) ([775ac0a](americanexpress@775ac0a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
customSnapshotIdentifierdo not add-snapsuffixMotivation and Context
It would be great not to force '-snap' suffix so users are able to customize file name providing
customSnapshotIdentifierThere are some discussion about this #107
How Has This Been Tested?
Current test cases passed. Some of them corrected.
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?
Better screenshots naming