chore(github): enable github actions #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAdshead
previously approved these changes
Jun 17, 2021
.github/workflows/health-check.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| node: [ '10.x', '12.x', '14.x' ] |
There was a problem hiding this comment.
Are these versions meant to be different for the health check vs tests?
There was a problem hiding this comment.
nope they should ideally be the same, i have updated them
.github/workflows/tests.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| node: [ '12.x', '14.x', '16.x' ] |
There was a problem hiding this comment.
We should probably test on 10 since we still support it and not supporting would be a breaking change.
JAdshead
approved these changes
Jun 17, 2021
anescobar1991
approved these changes
Jun 17, 2021
marcusrbrown
approved these changes
Jun 18, 2021
|
🎉 This PR is included in version 4.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use Github actions as travis.org is now discontinued
Description
Motivation and Context
How Has This Been Tested?
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?