Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Review jsx-props-no-spreading #118

Closed
amclin opened this issue Dec 2, 2019 · 2 comments · Fixed by #183
Closed

Review jsx-props-no-spreading #118

amclin opened this issue Dec 2, 2019 · 2 comments · Fixed by #183
Labels
enhancement New feature or request released

Comments

@amclin
Copy link
Owner

amclin commented Dec 2, 2019

Investigate if it is warranted to change the props spreading rule (jsx-props-no-spreading) in light of:
jsx-eslint/eslint-plugin-react#2439

We are using props-spreading with an explicit exception in the higher-order-component within _app.js when following the NextJS recommendation implementation of how to implement wrappers:
https://github.com/amclin/react-project-boilerplate/pull/114/files#diff-3d22b72961e012d82100ecc93f26b509R26

This rule has been updated in eslint-plugin-react v 7.17:
#115

@amclin amclin added the enhancement New feature or request label Dec 2, 2019
@KevinDanikowski
Copy link

AFter discussion it was said that we should just use individual //eslint-disable-next-line. There are now plentiful examples in the app and we can probably close this.

@amclin
Copy link
Owner Author

amclin commented Jan 15, 2020

🎉 This issue has been resolved in version 3.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants