Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic IVM writing from raw writers? #746

Open
zslayton opened this issue Apr 20, 2024 · 0 comments
Open

Remove automatic IVM writing from raw writers? #746

zslayton opened this issue Apr 20, 2024 · 0 comments

Comments

@zslayton
Copy link
Contributor

          Now that there's an application-level writer that can automate calling a `write_ivm()` method, I think we could remove the automatic functionality from the raw-level writers.

There's a minor design question around what to do for the 1.0 text writer. When the stream starts, it could leave off the $ion_1_0. However, if the user or application writer is calling write_ivm() to reset the encoding context, it could not leave it out. We could either have it always include a $ion_1_0 (unnecessary but pretty harmless) or we could pass an implicit_ivm_permitted: bool that other writers could just ignore.

Originally posted by @zslayton in #745 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant