Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature "experimental-lazy-reader" should enable "expermental-reader" #734

Open
jpschorr opened this issue Apr 3, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@jpschorr
Copy link
Contributor

jpschorr commented Apr 3, 2024

Given a Cargo.toml like

ion-rs = { version = "1.0.0-rc.3", features = ["experimental-lazy-reader"] }

Compiling ion-rs fails with errors like

   Compiling ion-rs v1.0.0-rc.3
error[E0432]: unresolved import `crate::RawSymbolTokenRef`
   --> /.../.cargo/registry/src/index.crates.io-6f17d22bba15001f/ion-rs-1.0.0-rc.3/src/lazy/any_encoding.rs:36:33
    |
36  | use crate::{IonResult, IonType, RawSymbolTokenRef};
    |                                 ^^^^^^^^^^^^^^^^^ no `RawSymbolTokenRef` in the root

This seems to be because "experimental-lazy-reader" implies "experimental-reader" as many features of the lazy reader use types defined in the experimental reader, but

experimental-lazy-reader = []

Has experimental-lazy-reader = [] and not experimental-lazy-reader = ["experimental-reader"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant