Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize experimental features, disable them by default #728

Open
zslayton opened this issue Mar 14, 2024 · 0 comments
Open

Reorganize experimental features, disable them by default #728

zslayton opened this issue Mar 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@zslayton
Copy link
Contributor

PR #727 started using the LazyReader for Element APIs, which caused a large number of export statements to conflict with conditional compilation. Lazy reader APIs wouldn't build unless experimental-lazy-reader was enabled, and experimental-lazy-reader had an undeclared dependency on experimental-reader and experimental-writer. We could no longer selectively enable specific features (without sweeping changes)--it was all-or-nothing.

We need to pare back the experimental features list; I propose collapsing experimental-lazy-reader, experimental-reader, and experimental-writer into an experimental-reader-writer. We would keep experimental-ion-hash and experimental-serde.

None would be enabled by default. Even when experimental-reader-writer is disabled, it will still be built with pub(crate) visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant